Issues still to be resolved
1. In share/TtHHbbSetups.py:
include( "AtlasGeoModel/SetGeometryVersion.py" )
include( "AtlasGeoModel/GeoModelInit.py" )
Athena warns that both of these files are obsolete - this does not lead to an ERROR or WARNING, but nonetheless needs to be looked at.
2. In src/PreselectLeptons.cxx:
const EMShower* shower;
if ((*elecItr)->author() != egammaParameters::AuthorUnknown){
trackIsolationEnergy20 = m_trackIsolationTool->trackIsolationEnergy((*elecItr)->trackParticle(),0.2);
trackIsolationEnergy30 = m_trackIsolationTool->trackIsolationEnergy((*elecItr)->trackParticle(),0.3);
trackIsolationEnergy40 = m_trackIsolationTool->trackIsolationEnergy((*elecItr)->trackParticle(),0.4);
shower = (*elecItr)->detail<EMShower>(m_showerContainerName);
//CCT: shower - seems to have stopped working in 15.6.0.2 for data made with r838 (v15.3.1.6)
//was giving a seg fault as it tried to get etcone20 even if "shower" had not been successfully obtained!
if (!shower) {
mLog << MSG::WARNING << "Invalid EMShower pointer!" << endreq;
}else{
etcone20 = shower->etcone20()/pT;
mLog << MSG::INFO << "shower->etcone20() = " << shower->etcone20() << ", pT = " << pT << endreq;
}
}
The warning message appears an awful lot - also, don't think this influences the Net inputs, but still should be looked at - do we need to get anything from the shower?
3. From the ye olde code, I noticed a 'placeholder' warning to check that W and top masses used in the sensible states are the same as in the generator (this hasn't been done yet). Also, perhaps we can tighten the sensible cut on the W mass? Seems rather wide at the mo (25GeV).... |